From e66e7f7c61de0868589da7a3f7a0cddd072de86b Mon Sep 17 00:00:00 2001 From: sspanak Date: Tue, 3 Jun 2025 11:09:12 +0300 Subject: [PATCH] better wording on the Punctuation Order screen --- .../punctuation/ItemPunctuationOrderSave.java | 11 +++++++++++ .../ItemRestoreDefaultPunctuation.java | 4 ++++ .../screens/punctuation/PunctuationScreen.java | 16 ++++++++++------ app/src/main/res/values-bg/strings.xml | 5 +++-- app/src/main/res/values-de/strings.xml | 5 +++-- app/src/main/res/values-es/strings.xml | 5 +++-- app/src/main/res/values-fr/strings.xml | 5 +++-- app/src/main/res/values-it/strings.xml | 5 +++-- app/src/main/res/values-iw/strings.xml | 5 +++-- app/src/main/res/values-lt/strings.xml | 5 +++-- app/src/main/res/values-nl/strings.xml | 5 +++-- app/src/main/res/values-pt-rBR/strings.xml | 5 +++-- app/src/main/res/values-ru/strings.xml | 5 +++-- app/src/main/res/values-tr/strings.xml | 5 +++-- app/src/main/res/values-uk/strings.xml | 5 +++-- app/src/main/res/values/strings.xml | 5 +++-- .../main/res/xml/prefs_screen_fn_key_order.xml | 2 +- .../main/res/xml/prefs_screen_punctuation.xml | 2 +- 18 files changed, 66 insertions(+), 34 deletions(-) diff --git a/app/src/main/java/io/github/sspanak/tt9/preferences/screens/punctuation/ItemPunctuationOrderSave.java b/app/src/main/java/io/github/sspanak/tt9/preferences/screens/punctuation/ItemPunctuationOrderSave.java index 749e19bc..4c963d40 100644 --- a/app/src/main/java/io/github/sspanak/tt9/preferences/screens/punctuation/ItemPunctuationOrderSave.java +++ b/app/src/main/java/io/github/sspanak/tt9/preferences/screens/punctuation/ItemPunctuationOrderSave.java @@ -2,17 +2,28 @@ package io.github.sspanak.tt9.preferences.screens.punctuation; import androidx.preference.Preference; +import io.github.sspanak.tt9.R; +import io.github.sspanak.tt9.languages.Language; import io.github.sspanak.tt9.preferences.items.ItemClickable; public class ItemPunctuationOrderSave extends ItemClickable { public static final String NAME = "punctuation_order_save"; private final Runnable clickHandler; + private Language language; public ItemPunctuationOrderSave(Preference item, Runnable clickHandler) { super(item); this.clickHandler = clickHandler; } + ItemPunctuationOrderSave setLanguage(Language language) { + this.language = language; + if (item != null) { + item.setTitle(item.getContext().getString(R.string.punctuation_order_save, language.getName())); + } + return this; + } + @Override protected boolean onClick(Preference p) { if (clickHandler == null) { diff --git a/app/src/main/java/io/github/sspanak/tt9/preferences/screens/punctuation/ItemRestoreDefaultPunctuation.java b/app/src/main/java/io/github/sspanak/tt9/preferences/screens/punctuation/ItemRestoreDefaultPunctuation.java index 1c41ab24..026bd336 100644 --- a/app/src/main/java/io/github/sspanak/tt9/preferences/screens/punctuation/ItemRestoreDefaultPunctuation.java +++ b/app/src/main/java/io/github/sspanak/tt9/preferences/screens/punctuation/ItemRestoreDefaultPunctuation.java @@ -3,6 +3,7 @@ package io.github.sspanak.tt9.preferences.screens.punctuation; import androidx.annotation.NonNull; import androidx.preference.Preference; +import io.github.sspanak.tt9.R; import io.github.sspanak.tt9.languages.Language; import io.github.sspanak.tt9.preferences.items.ItemClickable; import io.github.sspanak.tt9.preferences.settings.SettingsStore; @@ -23,6 +24,9 @@ class ItemRestoreDefaultPunctuation extends ItemClickable { ItemRestoreDefaultPunctuation setLanguage(Language language) { this.language = language; + if (item != null) { + item.setTitle(item.getContext().getString(R.string.punctuation_order_restore_default_for, language.getName())); + } return this; } diff --git a/app/src/main/java/io/github/sspanak/tt9/preferences/screens/punctuation/PunctuationScreen.java b/app/src/main/java/io/github/sspanak/tt9/preferences/screens/punctuation/PunctuationScreen.java index ac597abe..f57146b5 100644 --- a/app/src/main/java/io/github/sspanak/tt9/preferences/screens/punctuation/PunctuationScreen.java +++ b/app/src/main/java/io/github/sspanak/tt9/preferences/screens/punctuation/PunctuationScreen.java @@ -16,6 +16,7 @@ public class PunctuationScreen extends BaseScreenFragment { public static final String NAME = "Punctuation"; private ItemPunctuationOrderLanguage languageList; private ItemRestoreDefaultPunctuation restoreDefaults; + private ItemPunctuationOrderSave saveOrder; private final ArrayList charLists = new ArrayList<>(); public PunctuationScreen() { init(); } @@ -52,8 +53,9 @@ public class PunctuationScreen extends BaseScreenFragment { } initLanguageList(); - initResetDefaults(); - initSaveButton(); + Language initalLanguage = LanguageCollection.getLanguage(languageList.getValue()); + initResetDefaults(initalLanguage); + initSaveButton(initalLanguage); loadCharLists(); resetFontSize(false); } @@ -69,15 +71,16 @@ public class PunctuationScreen extends BaseScreenFragment { } - private void initSaveButton() { + private void initSaveButton(Language initialLanguage) { Preference item = findPreference(ItemPunctuationOrderSave.NAME); if (item != null) { - new ItemPunctuationOrderSave(item, this::onSaveOrdering).enableClickHandler(); + saveOrder = new ItemPunctuationOrderSave(item, this::onSaveOrdering).setLanguage(initialLanguage); + saveOrder.enableClickHandler(); } } - private void initResetDefaults() { + private void initResetDefaults(Language initialLanguage) { Preference item = findPreference(ItemRestoreDefaultPunctuation.NAME); if (item == null) { return; @@ -85,7 +88,7 @@ public class PunctuationScreen extends BaseScreenFragment { restoreDefaults = new ItemRestoreDefaultPunctuation(activity.getSettings(), item, this::onLanguageChanged); restoreDefaults - .setLanguage(LanguageCollection.getLanguage(languageList.getValue())) + .setLanguage(initialLanguage) .enableClickHandler(); } @@ -108,6 +111,7 @@ public class PunctuationScreen extends BaseScreenFragment { Language language = LanguageCollection.getLanguage(newLanguageId); restoreDefaults.setLanguage(language); + saveOrder.setLanguage(language); for (AbstractPreferenceCharList list : charLists) { if (list != null) { diff --git a/app/src/main/res/values-bg/strings.xml b/app/src/main/res/values-bg/strings.xml index 811be95d..e5fd39c3 100644 --- a/app/src/main/res/values-bg/strings.xml +++ b/app/src/main/res/values-bg/strings.xml @@ -204,9 +204,10 @@ Неуспешно запазване на реда на знаците. Ред на символите на клавиш 1 Ред на символите на клавиш 0 - Възстанови реда по подразбиране + Възстанови реда по подразбиране Език - Запази подредбата + Възстанови стандартната подредба за %1$s + Запази подредбата за %1$s Забранен символ:%1$s Забранени символи:%1$s Геометрия diff --git a/app/src/main/res/values-de/strings.xml b/app/src/main/res/values-de/strings.xml index 7a17f9bc..f61e91ef 100644 --- a/app/src/main/res/values-de/strings.xml +++ b/app/src/main/res/values-de/strings.xml @@ -192,9 +192,10 @@ Zeichenreihenfolge konnte nicht gespeichert werden. Zeichenreihenfolge der 1-Taste Zeichenreihenfolge der 0-Taste - Standardreihenfolge wiederherstellen + Standardreihenfolge wiederherstellen Sprache - Reihenfolge speichern + Standardreihenfolge für %1$s wiederherstellen + Reihenfolge für %1$s speichern Verbotenes Zeichen:%1$s Verbotene Zeichen:%1$s Text bearbeiten diff --git a/app/src/main/res/values-es/strings.xml b/app/src/main/res/values-es/strings.xml index 3b5ec8cf..8bdb4934 100644 --- a/app/src/main/res/values-es/strings.xml +++ b/app/src/main/res/values-es/strings.xml @@ -203,9 +203,10 @@ Error al guardar el orden de los caracteres. Orden de caracteres de la tecla 1 Orden de caracteres de la tecla 0 - Restaurar el orden predeterminado + Restaurar el orden predeterminado Idioma - Guardar orden + Restaurar el orden predeterminado para %1$s + Guardar el orden para %1$s Carácter prohibido:%1$s Caracteres prohibidos:%1$s Geometría diff --git a/app/src/main/res/values-fr/strings.xml b/app/src/main/res/values-fr/strings.xml index 881bec0c..9c3ebb63 100644 --- a/app/src/main/res/values-fr/strings.xml +++ b/app/src/main/res/values-fr/strings.xml @@ -201,9 +201,10 @@ Échec de l’enregistrement de l’ordre des caractères. Ordre des caractères de la touche 1 Ordre des caractères de la touche 0 - Restaurer l’ordre par défaut + Restaurer l’ordre par défaut Langue - Enregistrer l’ordre + Restaurer l’ordre par défaut pour %1$s + Enregistrer l’ordre pour %1$s Caractère interdit:%1$s Caractères interdits:%1$s Géométrie diff --git a/app/src/main/res/values-it/strings.xml b/app/src/main/res/values-it/strings.xml index aab6346d..141f62fa 100644 --- a/app/src/main/res/values-it/strings.xml +++ b/app/src/main/res/values-it/strings.xml @@ -190,9 +190,10 @@ Salvataggio dell’ordine dei caratteri non riuscito. Ordine dei caratteri del tasto 1 Ordine dei caratteri del tasto 0 - Ripristina ordine predefinito + Ripristina ordine predefinito Lingua - Salvare l\'ordine + Ripristina l’ordine predefinito per %1$s + Salva l’ordine per %1$s Carattere vietato:%1$s Caratteri vietati:%1$s Modifica testo diff --git a/app/src/main/res/values-iw/strings.xml b/app/src/main/res/values-iw/strings.xml index 3d51530b..fda14d99 100644 --- a/app/src/main/res/values-iw/strings.xml +++ b/app/src/main/res/values-iw/strings.xml @@ -204,9 +204,10 @@ שמירת סדר התווים נכשלה. סדר התווים של מקש 1 סדר התווים של מקש 0 - שחזר את הסדר המוגדר כברירת מחדל + שחזר את הסדר המוגדר כברירת מחדל שפה - שמור את הסדר + שחזר את הסדר המוגדר כברירת מחדל עבור ‎%1$s + שמור את הסדר עבור ‎%1$s תו אסור:%1$s תווים אסורים:%1$s סינון הצעות diff --git a/app/src/main/res/values-lt/strings.xml b/app/src/main/res/values-lt/strings.xml index 41311b05..418c7842 100644 --- a/app/src/main/res/values-lt/strings.xml +++ b/app/src/main/res/values-lt/strings.xml @@ -212,9 +212,10 @@ Nepavyko išsaugoti simbolių tvarkos. Simbolių tvarka ant klavišo 1 Simbolių tvarka ant klavišo 0 - Atkurti numatytąją tvarką + Atkurti numatytąją tvarką Kalba - Išsaugoti tvarką + Atkurti numatytąją tvarką %1$s + Išsaugoti tvarką %1$s Draudžiamas simbolis:%1$s Draudžiami simboliai:%1$s Geometrija diff --git a/app/src/main/res/values-nl/strings.xml b/app/src/main/res/values-nl/strings.xml index 7b9de258..447f4ef6 100644 --- a/app/src/main/res/values-nl/strings.xml +++ b/app/src/main/res/values-nl/strings.xml @@ -192,9 +192,10 @@ Opslaan van de tekenvolgorde mislukt. Tekenvolgorde van de 1-toets Tekenvolgorde van de 0-toets - Standaardvolgorde herstellen + Standaardvolgorde herstellen Taal - Volgorde opslaan + Standaardvolgorde herstellen voor %1$s + Volgorde opslaan voor %1$s Verboden teken:%1$s Verboden tekens:%1$s Tekst bewerken diff --git a/app/src/main/res/values-pt-rBR/strings.xml b/app/src/main/res/values-pt-rBR/strings.xml index 5c6e20b1..f7d246c0 100644 --- a/app/src/main/res/values-pt-rBR/strings.xml +++ b/app/src/main/res/values-pt-rBR/strings.xml @@ -205,9 +205,10 @@ Falha ao salvar a ordem dos caracteres. Ordem de caracteres da tecla 1 Ordem de caracteres da tecla 0 - Restaurar ordem padrão + Restaurar ordem padrão Idioma - Salvar ordem + Restaurar a ordem padrão para %1$s + Salvar a ordem para %1$s Caractere proibido:%1$s Caracteres proibidos:%1$s Filtrar de Sugestões diff --git a/app/src/main/res/values-ru/strings.xml b/app/src/main/res/values-ru/strings.xml index 09221334..8b101f67 100644 --- a/app/src/main/res/values-ru/strings.xml +++ b/app/src/main/res/values-ru/strings.xml @@ -203,9 +203,10 @@ е удалось сохранить порядок символов. Порядок символов на клавише 1 Порядок символов на клавише 0 - Восстановить порядок по умолчанию + Восстановить порядок по умолчанию Язык - Сохранить порядок + Восстановить порядок по умолчанию для %1$s + Сохранить порядок для %1$s Запрещённый символ:%1$s Запрещённые символы:%1$s Геометрия diff --git a/app/src/main/res/values-tr/strings.xml b/app/src/main/res/values-tr/strings.xml index fcebf544..4793e90e 100644 --- a/app/src/main/res/values-tr/strings.xml +++ b/app/src/main/res/values-tr/strings.xml @@ -205,9 +205,10 @@ Karakter sırası kaydedilemedi. 1 tuşunun karakter sırası 0 tuşunun karakter sırası - Varsayılan sırayı geri yükle + Varsayılan sırayı geri yükle Dil - Sıralamayı kaydet + %1$s için varsayılan sırayı geri yükle + %1$s için sırayı kaydet Yasaklı karakter:%1$s Yasaklı karakterler:%1$s Geometri diff --git a/app/src/main/res/values-uk/strings.xml b/app/src/main/res/values-uk/strings.xml index ab969e89..034e069b 100644 --- a/app/src/main/res/values-uk/strings.xml +++ b/app/src/main/res/values-uk/strings.xml @@ -214,9 +214,10 @@ Не вдалося зберегти порядок символів. Порядок символів на клавіші 1 Порядок символів на клавіші 0 - Відновити початковий порядок + Відновити початковий порядок Мова - Зберегти порядок + Відновити порядок за замовчуванням для %1$s + Зберегти порядок для %1$s Заборонений символ:%1$s Заборонені символи:%1$s Геометрія diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 15dedf31..b5813c4e 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -8,7 +8,6 @@ English only Loading… Language - Restore Default Order Search Results No results. @@ -171,6 +170,7 @@ No duplicate keys allowed. Legend: Hint: After reordering the keys in column 1, tap on column 2 to see the result immediately (or vice versa). + Restore Default Order Key \"%1$s\" is already assigned to function \"%2$s\". Do you want to assign it to \"%3$s\"? * Press or hold a key to assign it to the \"%1$s\" function.\n\n* Press 0 to cancel.\n\n* Press 2 to disable the function. @@ -210,7 +210,8 @@ Missing mandatory characters:%1$s Forbidden character:%1$s Forbidden characters:%1$s - Save Order + Restore Default Order for %1$s + Save Order for %1$s Failed saving the character order. 1-key Character Order 0-key Character Order diff --git a/app/src/main/res/xml/prefs_screen_fn_key_order.xml b/app/src/main/res/xml/prefs_screen_fn_key_order.xml index 5b4673a9..67358771 100644 --- a/app/src/main/res/xml/prefs_screen_fn_key_order.xml +++ b/app/src/main/res/xml/prefs_screen_fn_key_order.xml @@ -8,6 +8,6 @@ app:key="pref_rfn_key_order" app:title="@string/fn_key_order_column_2" /> - + diff --git a/app/src/main/res/xml/prefs_screen_punctuation.xml b/app/src/main/res/xml/prefs_screen_punctuation.xml index 65675061..37d2ff67 100644 --- a/app/src/main/res/xml/prefs_screen_punctuation.xml +++ b/app/src/main/res/xml/prefs_screen_punctuation.xml @@ -40,7 +40,7 @@ + android:title="@string/punctuation_order_restore_default_for" />