From 3d2a5a0c30bf399833eb2115d59be7a56367bda5 Mon Sep 17 00:00:00 2001 From: sspanak Date: Thu, 30 Jan 2025 11:38:16 +0200 Subject: [PATCH] adjusted the numpad keys spacing properly --- .../preferences/custom/ScreenPreference.java | 4 +- .../sspanak/tt9/ui/main/MainLayoutNumpad.java | 2 +- .../tt9/ui/main/keys/SwipeableKey.java | 2 +- ...f_category.xml => pref_category_large.xml} | 8 +-- .../main/res/layout/pref_default_large.xml | 8 +-- .../main/res/layout/pref_deletable_word.xml | 4 +- .../res/layout/pref_deletable_word_large.xml | 6 +-- ...f_dropdown.xml => pref_dropdown_large.xml} | 8 +-- app/src/main/res/layout/pref_input_text.xml | 6 +-- .../main/res/layout/pref_input_text_large.xml | 12 ++--- app/src/main/res/layout/pref_plain_text.xml | 6 +-- .../main/res/layout/pref_plain_text_large.xml | 8 +-- app/src/main/res/layout/pref_search_v31.xml | 2 +- app/src/main/res/layout/pref_switch_large.xml | 12 ++--- app/src/main/res/values/dimens.xml | 42 +++++++++------ app/src/main/res/values/styles.xml | 53 +++++++++++-------- 16 files changed, 99 insertions(+), 84 deletions(-) rename app/src/main/res/layout/{pref_category.xml => pref_category_large.xml} (66%) rename app/src/main/res/layout/{pref_dropdown.xml => pref_dropdown_large.xml} (81%) diff --git a/app/src/main/java/io/github/sspanak/tt9/preferences/custom/ScreenPreference.java b/app/src/main/java/io/github/sspanak/tt9/preferences/custom/ScreenPreference.java index 2105051e..a4a4ddb2 100644 --- a/app/src/main/java/io/github/sspanak/tt9/preferences/custom/ScreenPreference.java +++ b/app/src/main/java/io/github/sspanak/tt9/preferences/custom/ScreenPreference.java @@ -45,11 +45,11 @@ abstract public class ScreenPreference extends Preference { public static int getLargeLayout(Preference pref) { if (pref instanceof PreferenceCategory) { - return R.layout.pref_category; + return R.layout.pref_category_large; } else if (pref instanceof SwitchPreferenceCompat) { return R.layout.pref_switch_large; } else if (pref instanceof DropDownPreference) { - return R.layout.pref_dropdown; + return R.layout.pref_dropdown_large; } else { return R.layout.pref_default_large; } diff --git a/app/src/main/java/io/github/sspanak/tt9/ui/main/MainLayoutNumpad.java b/app/src/main/java/io/github/sspanak/tt9/ui/main/MainLayoutNumpad.java index 2cc6cb66..634886aa 100644 --- a/app/src/main/java/io/github/sspanak/tt9/ui/main/MainLayoutNumpad.java +++ b/app/src/main/java/io/github/sspanak/tt9/ui/main/MainLayoutNumpad.java @@ -165,7 +165,7 @@ class MainLayoutNumpad extends BaseMainLayout { Resources resources = tt9.getResources(); height = getKeyHeightCompat() * 4 + resources.getDimensionPixelSize(R.dimen.numpad_suggestion_height) - + Math.round(resources.getDimension(R.dimen.numpad_padding_bottom)) + + Math.round(resources.getDimension(R.dimen.numpad_spacing_bottom)) + getBottomInsetSize(); } diff --git a/app/src/main/java/io/github/sspanak/tt9/ui/main/keys/SwipeableKey.java b/app/src/main/java/io/github/sspanak/tt9/ui/main/keys/SwipeableKey.java index 0c3c1729..4ff0be0c 100644 --- a/app/src/main/java/io/github/sspanak/tt9/ui/main/keys/SwipeableKey.java +++ b/app/src/main/java/io/github/sspanak/tt9/ui/main/keys/SwipeableKey.java @@ -80,7 +80,7 @@ abstract public class SwipeableKey extends SoftKey { try { // The simpler getResource.getFloat() requires API 29, so we must get the value manually. TypedValue outValue = new TypedValue(); - getResources().getValue(R.dimen.numpad_function_key_layout_weight, outValue, true); + getResources().getValue(R.dimen.numpad_key_fn_layout_weight, outValue, true); float functionKeyScale = outValue.getFloat(); float keyWidth = tt9.getWidth() / 5f * functionKeyScale; diff --git a/app/src/main/res/layout/pref_category.xml b/app/src/main/res/layout/pref_category_large.xml similarity index 66% rename from app/src/main/res/layout/pref_category.xml rename to app/src/main/res/layout/pref_category_large.xml index 5c152b5b..21d8b8d8 100644 --- a/app/src/main/res/layout/pref_category.xml +++ b/app/src/main/res/layout/pref_category_large.xml @@ -3,9 +3,9 @@ android:orientation="vertical" android:layout_width="match_parent" android:layout_height="wrap_content" - android:paddingHorizontal="@dimen/pref_large_padding_horizontal" - android:paddingTop="@dimen/pref_large_category_padding_top" - android:paddingBottom="@dimen/pref_large_category_padding_bottom"> + android:paddingHorizontal="@dimen/large_pref_spacing_horizontal" + android:paddingTop="@dimen/large_pref_category_spacing_top" + android:paddingBottom="@dimen/large_pref_category_spacing_bottom"> + android:textSize="@dimen/large_pref_text_size" /> diff --git a/app/src/main/res/layout/pref_default_large.xml b/app/src/main/res/layout/pref_default_large.xml index 53e97d71..aadff9b9 100644 --- a/app/src/main/res/layout/pref_default_large.xml +++ b/app/src/main/res/layout/pref_default_large.xml @@ -3,18 +3,18 @@ android:orientation="vertical" android:layout_width="match_parent" android:layout_height="wrap_content" - android:paddingHorizontal="@dimen/pref_large_padding_horizontal" - android:paddingVertical="@dimen/pref_large_padding_vertical"> + android:paddingHorizontal="@dimen/large_pref_spacing_horizontal" + android:paddingVertical="@dimen/large_pref_spacing_vertical"> + android:textSize="@dimen/large_pref_text_size" /> + android:textSize="@dimen/large_pref_summary_size" /> diff --git a/app/src/main/res/layout/pref_deletable_word.xml b/app/src/main/res/layout/pref_deletable_word.xml index 6cb3b247..a3ab21ca 100644 --- a/app/src/main/res/layout/pref_deletable_word.xml +++ b/app/src/main/res/layout/pref_deletable_word.xml @@ -5,8 +5,8 @@ android:layout_width="match_parent" android:layout_height="wrap_content" android:orientation="horizontal" - android:paddingHorizontal="@dimen/pref_padding_horizontal" - android:paddingVertical="@dimen/pref_padding_vertical" + android:paddingHorizontal="@dimen/pref_custom_spacing_horizontal" + android:paddingVertical="@dimen/pref_custom_spacing_vertical" app:layout_anchorGravity="center_horizontal"> diff --git a/app/src/main/res/layout/pref_dropdown.xml b/app/src/main/res/layout/pref_dropdown_large.xml similarity index 81% rename from app/src/main/res/layout/pref_dropdown.xml rename to app/src/main/res/layout/pref_dropdown_large.xml index 5a299bd0..c70f4400 100644 --- a/app/src/main/res/layout/pref_dropdown.xml +++ b/app/src/main/res/layout/pref_dropdown_large.xml @@ -4,8 +4,8 @@ android:layout_height="wrap_content" android:baselineAligned="false" android:orientation="horizontal" - android:paddingHorizontal="@dimen/pref_large_padding_horizontal" - android:paddingVertical="@dimen/pref_large_padding_vertical"> + android:paddingHorizontal="@dimen/large_pref_spacing_horizontal" + android:paddingVertical="@dimen/large_pref_spacing_vertical"> + android:textSize="@dimen/large_pref_text_size" /> + android:textSize="@dimen/large_pref_summary_size" /> diff --git a/app/src/main/res/layout/pref_input_text.xml b/app/src/main/res/layout/pref_input_text.xml index cfcc49bb..858b9d70 100644 --- a/app/src/main/res/layout/pref_input_text.xml +++ b/app/src/main/res/layout/pref_input_text.xml @@ -4,8 +4,8 @@ android:orientation="vertical" android:layout_width="match_parent" android:layout_height="wrap_content" - android:paddingHorizontal="@dimen/pref_padding_horizontal" - android:paddingVertical="@dimen/pref_padding_vertical"> + android:paddingHorizontal="@dimen/pref_custom_spacing_horizontal" + android:paddingVertical="@dimen/pref_custom_spacing_vertical"> diff --git a/app/src/main/res/layout/pref_input_text_large.xml b/app/src/main/res/layout/pref_input_text_large.xml index 566725b3..7528f3f1 100644 --- a/app/src/main/res/layout/pref_input_text_large.xml +++ b/app/src/main/res/layout/pref_input_text_large.xml @@ -4,8 +4,8 @@ android:orientation="vertical" android:layout_width="match_parent" android:layout_height="wrap_content" - android:paddingHorizontal="@dimen/pref_large_padding_horizontal" - android:paddingVertical="@dimen/pref_large_padding_vertical"> + android:paddingHorizontal="@dimen/large_pref_spacing_horizontal" + android:paddingVertical="@dimen/large_pref_spacing_vertical"> + android:textSize="@dimen/large_pref_summary_size"/> + android:minHeight="@dimen/pref_custom_min_height" + android:textSize="@dimen/large_pref_text_size" /> + android:textSize="@dimen/large_pref_summary_size" /> diff --git a/app/src/main/res/layout/pref_plain_text.xml b/app/src/main/res/layout/pref_plain_text.xml index 9db4620e..c93ee833 100644 --- a/app/src/main/res/layout/pref_plain_text.xml +++ b/app/src/main/res/layout/pref_plain_text.xml @@ -3,12 +3,12 @@ android:orientation="vertical" android:layout_width="match_parent" android:layout_height="wrap_content" - android:paddingHorizontal="@dimen/pref_padding_horizontal" - android:paddingVertical="@dimen/pref_padding_vertical"> + android:paddingHorizontal="@dimen/pref_custom_spacing_horizontal" + android:paddingVertical="@dimen/pref_custom_spacing_vertical"> + android:minHeight="@dimen/pref_custom_min_height" /> diff --git a/app/src/main/res/layout/pref_plain_text_large.xml b/app/src/main/res/layout/pref_plain_text_large.xml index b1783bf1..34dca9eb 100644 --- a/app/src/main/res/layout/pref_plain_text_large.xml +++ b/app/src/main/res/layout/pref_plain_text_large.xml @@ -3,13 +3,13 @@ android:orientation="vertical" android:layout_width="match_parent" android:layout_height="wrap_content" - android:paddingHorizontal="@dimen/pref_large_padding_horizontal" - android:paddingVertical="@dimen/pref_large_padding_vertical"> + android:paddingHorizontal="@dimen/large_pref_spacing_horizontal" + android:paddingVertical="@dimen/large_pref_spacing_vertical"> + android:minHeight="@dimen/pref_custom_min_height" + android:textSize="@dimen/large_pref_summary_size" /> diff --git a/app/src/main/res/layout/pref_search_v31.xml b/app/src/main/res/layout/pref_search_v31.xml index f428336a..09d4b71b 100644 --- a/app/src/main/res/layout/pref_search_v31.xml +++ b/app/src/main/res/layout/pref_search_v31.xml @@ -3,7 +3,7 @@ xmlns:android="http://schemas.android.com/apk/res/android" xmlns:app="http://schemas.android.com/apk/res-auto" android:layout_width="match_parent" - android:layout_height="@dimen/preference_search_height"> + android:layout_height="@dimen/pref_search_height"> + android:paddingBottom="@dimen/large_pref_spacing_vertical"> + android:textSize="@dimen/large_pref_text_size" /> + android:textSize="@dimen/large_pref_summary_size" /> + android:paddingEnd="@dimen/large_pref_spacing_horizontal" /> diff --git a/app/src/main/res/values/dimens.xml b/app/src/main/res/values/dimens.xml index 8473fd36..79d13e9d 100644 --- a/app/src/main/res/values/dimens.xml +++ b/app/src/main/res/values/dimens.xml @@ -13,7 +13,7 @@ 16sp - 6sp + 6sp 18sp 32sp @@ -21,32 +21,40 @@ 46dp - 48dp - 72dp - 16dp - 12dp + 48dp + 16dp + 12dp + 72dp - 30dp - 12dp - 16dp - 18dp - 22sp - 19sp + 30dp + 12dp + + 16dp + 18dp + 22sp + 19sp 9999dp - 6dp + 6dp 56dp - 38dp - 0.675 + 3dp + 38dp + 0.675 666dp - 13dp - 11dp - 2dp + 9dp + 13dp + 11dp + + 2dp + 4dp + 3dp + 3dp + 5dp 17sp 40sp diff --git a/app/src/main/res/values/styles.xml b/app/src/main/res/values/styles.xml index ff0adb02..d4b78d32 100644 --- a/app/src/main/res/values/styles.xml +++ b/app/src/main/res/values/styles.xml @@ -60,8 +60,8 @@ center wrap_content match_parent - @dimen/main_small_suggestion_padding_horizontal - @dimen/main_small_suggestion_padding_horizontal + @dimen/main_small_suggestion_spacing_horizontal + @dimen/main_small_suggestion_spacing_horizontal @@ -289,8 +293,12 @@ @@ -319,9 +326,9 @@