wzray/tt9
1
0
Fork 0
Code Activity

disabled 'send with OK in Messenger'

Browse source
This commit is contained in:
Dimo Karaivanov 2024-07-03 11:02:10 +03:00
parent a82f8c783e
commit 1ee0a4485f
6 changed files with 3 additions and 36 deletions
Download patch file Download diff file Expand all files Collapse all files

19
app/src/main/java/io/github/sspanak/tt9/hacks/AppHacks.java
View file

@ -100,9 +100,7 @@ public class AppHacks {
* it does nothing and return "false", signaling the system we have ignored the key press.
*/
public boolean onEnter() {
if (settings.getFbMessengerHack() && inputType.isMessenger()) {
return onEnterFbMessenger();
} else if (settings.getGoogleChatHack() && inputType.isGoogleChat()) {
if (settings.getGoogleChatHack() && inputType.isGoogleChat()) {
return onEnterGoogleChat();
} else if (inputType.isTermux() || inputType.isMultilineTextInNonSystemApp()) {
// Termux supports only ENTER, so we convert DPAD_CENTER for it.
@ -117,21 +115,6 @@ public class AppHacks {
return false;
}
/**
* onEnterFbMessenger
* Messenger responds only to ENTER, but not DPAD_CENTER, so we make sure to send the correct code,
* no matter how the hardware key is implemented.
*/
private boolean onEnterFbMessenger() {
if (inputConnection == null || textField == null || textField.isEmpty()) {
return false;
}
sendDownUpKeyEvents(KeyEvent.KEYCODE_ENTER);
return true;
}
/**
* onEnterGoogleChat
* Google Chat does not seem to respond consistently to ENTER. So we trick it by selecting

8
app/src/main/java/io/github/sspanak/tt9/hacks/InputType.java
View file

@ -56,14 +56,6 @@ public class InputType extends StandardInputType {
}
boolean isMessenger() {
return isAppField(
"com.facebook.orca",
EditorInfo.TYPE_CLASS_TEXT | EditorInfo.TYPE_TEXT_FLAG_MULTI_LINE | EditorInfo.TYPE_TEXT_FLAG_CAP_SENTENCES
);
}
/**
* Third-party apps are usually designed for a touch screen, so the least we can do is convert
* DPAD_CENTER to ENTER for typing new lines, regardless of the implementation of the OK key.

5
app/src/main/java/io/github/sspanak/tt9/preferences/screens/setup/SetupScreen.java
View file

@ -52,10 +52,5 @@ public class SetupScreen extends BaseScreenFragment {
if (hackGoogleChat != null) {
hackGoogleChat.setEnabled(isEnabled);
}
Preference hackFBMessenger = findPreference("pref_hack_fb_messenger");
if (hackFBMessenger != null) {
hackFBMessenger.setEnabled(isEnabled);
}
}
}

4
app/src/main/java/io/github/sspanak/tt9/preferences/settings/SettingsHacks.java
View file

@ -46,10 +46,6 @@ class SettingsHacks extends BaseSettings {
return prefs.getBoolean("pref_clear_insets", DeviceInfo.isSonimGen2(context));
}
public boolean getFbMessengerHack() {
return prefs.getBoolean("pref_hack_fb_messenger", false);
}
public boolean getGoogleChatHack() {
return prefs.getBoolean("pref_hack_google_chat", false);
}

1
app/src/main/res/xml/prefs_screen_setup.xml
View file

@ -19,6 +19,7 @@
<SwitchPreferenceCompat
app:defaultValue="false"
app:enabled="false"
app:key="pref_hack_fb_messenger"
app:title="@string/pref_hack_fb_messenger"/>

2
docs/user-manual.md
View file

@ -230,7 +230,7 @@ _**Note 2:** Besides the above, Qin phones may also fail to detect long presses.
#### Send messages with OK in Facebook Messenger
_In: Settings → Initial Setup._
Facebook Messenger fails to recognize the OK key on some devices, making it impossible to send messages with it. If you prefer to send messages using OK, instead of Messenger's own send button, enable this option. This ensures sending is possible on any phone.
Sending with OK in Messenger has been no longer possible since the June 2024 update. The recent app redesign caused the Send button to become unreachable for all keyboards. If you have technical knowledge and an idea of how to re-enable this feature, please write in [this GitHub issue](https://github.com/sspanak/tt9/issues/558).
#### Send messages with OK in Google Chat