From 1baca0a50b009d5e003bb262f6c39fe0d303c7ad Mon Sep 17 00:00:00 2001 From: sspanak Date: Wed, 16 Oct 2024 12:27:01 +0300 Subject: [PATCH] removed the 'send with ENTER in Google Chat' option as it no longer works --- .../io/github/sspanak/tt9/hacks/AppHacks.java | 25 +------------------ .../github/sspanak/tt9/hacks/InputType.java | 8 ------ .../screens/setup/SetupScreen.java | 8 ------ .../preferences/settings/SettingsHacks.java | 4 --- app/src/main/res/values-bg/strings.xml | 1 - app/src/main/res/values-de/strings.xml | 1 - app/src/main/res/values-es/strings.xml | 1 - app/src/main/res/values-fr/strings.xml | 1 - app/src/main/res/values-it/strings.xml | 1 - app/src/main/res/values-iw/strings.xml | 1 - app/src/main/res/values-lt/strings.xml | 1 - app/src/main/res/values-nl/strings.xml | 1 - app/src/main/res/values-pt-rBR/strings.xml | 1 - app/src/main/res/values-ru/strings.xml | 1 - app/src/main/res/values-tr/strings.xml | 1 - app/src/main/res/values-uk/strings.xml | 1 - app/src/main/res/values/strings.xml | 1 - app/src/main/res/xml/prefs_screen_setup.xml | 6 ----- docs/user-manual.md | 10 +------- 19 files changed, 2 insertions(+), 72 deletions(-) diff --git a/app/src/main/java/io/github/sspanak/tt9/hacks/AppHacks.java b/app/src/main/java/io/github/sspanak/tt9/hacks/AppHacks.java index 5d331d41..2cf9a363 100644 --- a/app/src/main/java/io/github/sspanak/tt9/hacks/AppHacks.java +++ b/app/src/main/java/io/github/sspanak/tt9/hacks/AppHacks.java @@ -120,9 +120,7 @@ public class AppHacks { * it does nothing and return "false", signaling the system we have ignored the key press. */ public boolean onEnter() { - if (settings.getGoogleChatHack() && inputType.isGoogleChat()) { - return onEnterGoogleChat(); - } else if (inputType.isTermux() || inputType.isMultilineTextInNonSystemApp()) { + if (inputType.isTermux() || inputType.isMultilineTextInNonSystemApp()) { // Termux supports only ENTER, so we convert DPAD_CENTER for it. // Any extra installed apps are likely not designed for hardware keypads, so again, // we don't want to send DPAD_CENTER to them. @@ -134,25 +132,4 @@ public class AppHacks { // As per the docs, we must return "false", to indicate that we have not "seen" the key press. return false; } - - /** - * onEnterGoogleChat - * Google Chat does not seem to respond consistently to ENTER. So we trick it by selecting - * the send button it, then going back to the text field, so that one can continue typing. - */ - private boolean onEnterGoogleChat() { - if (inputConnection == null || textField == null || textField.isEmpty()) { - return false; - } - - textField.sendDownUpKeyEvents(KeyEvent.KEYCODE_TAB); - textField.sendDownUpKeyEvents(KeyEvent.KEYCODE_TAB); - textField.sendDownUpKeyEvents(KeyEvent.KEYCODE_ENTER); - textField.sendDownUpKeyEvents(KeyEvent.KEYCODE_TAB, true, false); - textField.sendDownUpKeyEvents(KeyEvent.KEYCODE_TAB, true, false); - textField.sendDownUpKeyEvents(KeyEvent.KEYCODE_TAB, true, false); - textField.sendDownUpKeyEvents(KeyEvent.KEYCODE_TAB, true, false); - - return true; - } } diff --git a/app/src/main/java/io/github/sspanak/tt9/hacks/InputType.java b/app/src/main/java/io/github/sspanak/tt9/hacks/InputType.java index 977c3e22..2233b5ec 100644 --- a/app/src/main/java/io/github/sspanak/tt9/hacks/InputType.java +++ b/app/src/main/java/io/github/sspanak/tt9/hacks/InputType.java @@ -17,14 +17,6 @@ public class InputType extends StandardInputType { } - boolean isGoogleChat() { - return isAppField( - "com.google.android.apps.dynamite", - EditorInfo.TYPE_CLASS_TEXT | EditorInfo.TYPE_TEXT_FLAG_MULTI_LINE | EditorInfo.TYPE_TEXT_FLAG_CAP_SENTENCES | EditorInfo.TYPE_TEXT_FLAG_AUTO_CORRECT - ); - } - - /** * isKindleInvertedTextField * When sharing a document to the Amazon Kindle app. It displays a screen where one could edit the title and the author of the diff --git a/app/src/main/java/io/github/sspanak/tt9/preferences/screens/setup/SetupScreen.java b/app/src/main/java/io/github/sspanak/tt9/preferences/screens/setup/SetupScreen.java index 70da9717..b501e120 100644 --- a/app/src/main/java/io/github/sspanak/tt9/preferences/screens/setup/SetupScreen.java +++ b/app/src/main/java/io/github/sspanak/tt9/preferences/screens/setup/SetupScreen.java @@ -20,7 +20,6 @@ public class SetupScreen extends BaseScreenFragment { public void onCreate() { boolean isTT9On = SystemSettings.isTT9Enabled(activity); createKeyboardSection(isTT9On); - createHacksSection(isTT9On | activity.getSettings().getDemoMode()); resetFontSize(false); } @@ -48,11 +47,4 @@ public class SetupScreen extends BaseScreenFragment { new ItemSpellCheck(activity, findPreference("global_spellchecker")).enableClickHandler(); } - - private void createHacksSection(boolean isEnabled) { - Preference hackGoogleChat = findPreference("pref_hack_google_chat"); - if (hackGoogleChat != null) { - hackGoogleChat.setEnabled(isEnabled); - } - } } diff --git a/app/src/main/java/io/github/sspanak/tt9/preferences/settings/SettingsHacks.java b/app/src/main/java/io/github/sspanak/tt9/preferences/settings/SettingsHacks.java index 43042fbd..1413ed1d 100644 --- a/app/src/main/java/io/github/sspanak/tt9/preferences/settings/SettingsHacks.java +++ b/app/src/main/java/io/github/sspanak/tt9/preferences/settings/SettingsHacks.java @@ -46,10 +46,6 @@ class SettingsHacks extends BaseSettings { return prefs.getBoolean("pref_clear_insets", DeviceInfo.isSonimGen2(context)); } - public boolean getGoogleChatHack() { - return prefs.getBoolean("pref_hack_google_chat", false); - } - /** * Protection against faulty devices, that sometimes send two (or more) click events * per a single key press, which absolutely undesirable side effects. diff --git a/app/src/main/res/values-bg/strings.xml b/app/src/main/res/values-bg/strings.xml index eb1c92e7..a05dd145 100644 --- a/app/src/main/res/values-bg/strings.xml +++ b/app/src/main/res/values-bg/strings.xml @@ -49,7 +49,6 @@ Изпращай с „ОК“ във Facebook Messenger Винаги видим Не позволява на другите приложения да покриват %1$s или да го изместват извън екрана. - Изпращай съобщения с „ОК“ в Google Chat Назад Зелена слушалка Експортирай избраните diff --git a/app/src/main/res/values-de/strings.xml b/app/src/main/res/values-de/strings.xml index 70f27bbd..96c92d3b 100644 --- a/app/src/main/res/values-de/strings.xml +++ b/app/src/main/res/values-de/strings.xml @@ -120,7 +120,6 @@ Zeichen bei doppeltem Drücken der Taste „0“ Immer im Vordergrund Andere Anwendungen nicht erlauben, %1$s zu überdecken oder vom Bildschirm zu schieben. - Nachrichten mit \"OK\" in Google Chat senden Schutz vor versehentlichem Tastenwiederholen Aus Export abgeschlossen diff --git a/app/src/main/res/values-es/strings.xml b/app/src/main/res/values-es/strings.xml index 0ffc9078..6a5c922d 100644 --- a/app/src/main/res/values-es/strings.xml +++ b/app/src/main/res/values-es/strings.xml @@ -133,7 +133,6 @@ Enviar con «OK» en Facebook Messenger Siempre encima No permitir que otras aplicaciones cubran %1$s o lo empujen fuera de la pantalla. - Enviar mensajes con «OK» en Google Chat Protección contra la repetición accidental de teclas Apagado " Exportación completada" diff --git a/app/src/main/res/values-fr/strings.xml b/app/src/main/res/values-fr/strings.xml index 65d40940..5369403f 100644 --- a/app/src/main/res/values-fr/strings.xml +++ b/app/src/main/res/values-fr/strings.xml @@ -50,7 +50,6 @@ Envoyer avec «OK» dans Facebook Messenger Toujours au premier plan Ne pas permettre aux autres applications de couvrir %1$s ou de le pousser hors de l\'écran. - Envoyer des messages avec «OK» dans Google Chat Chargement du dictionnaire Échec du téléchargement du dictionnaire pour la langue « %1$s ». Vérifiez la connexion Internet. Chargement est annulé. diff --git a/app/src/main/res/values-it/strings.xml b/app/src/main/res/values-it/strings.xml index f51c9a99..e064306a 100644 --- a/app/src/main/res/values-it/strings.xml +++ b/app/src/main/res/values-it/strings.xml @@ -121,7 +121,6 @@ Simbolo quando si preme due volte il tasto \"0\" Sempre in primo piano Non consentire ad altre applicazioni di coprire %1$s o di spingerlo fuori dallo schermo. - Inviare messaggi con \"OK\" su Google Chat Protezione contro la ripetizione accidentale dei tasti Spento Esportazione completata diff --git a/app/src/main/res/values-iw/strings.xml b/app/src/main/res/values-iw/strings.xml index 96b46571..bbf12298 100644 --- a/app/src/main/res/values-iw/strings.xml +++ b/app/src/main/res/values-iw/strings.xml @@ -133,7 +133,6 @@ שלח עם \"OK\" ב-Facebook Messenger. נראה תמיד אל תאפשר ליישומים אחרים לכסות %1$s או לדחות אותו מהמסך. - שלח הודעות עם \"OK\" ב-Google Chat הגנה מפני חזרת מפתח בשוגג כבוי הייצוא הושלם diff --git a/app/src/main/res/values-lt/strings.xml b/app/src/main/res/values-lt/strings.xml index 1fcc2f14..bbc8a2c8 100644 --- a/app/src/main/res/values-lt/strings.xml +++ b/app/src/main/res/values-lt/strings.xml @@ -117,7 +117,6 @@ Trinti pridėtus žodžius Visada viršuje Neleisti kitiems programoms uždengti %1$s arba atstumti jį nuo ekrano. - Siųsti žinutes su „OK“ „Google Chat“ programoje Apsauga nuo atsitiktinio rakto pasikartojimo Išjungta Prašome palaukti, kol žodynas bus įkeltas. diff --git a/app/src/main/res/values-nl/strings.xml b/app/src/main/res/values-nl/strings.xml index f7f306eb..92ca88c8 100644 --- a/app/src/main/res/values-nl/strings.xml +++ b/app/src/main/res/values-nl/strings.xml @@ -119,7 +119,6 @@ Teken bij dubbelklikken op toets \"0\" Altijd bovenaan Andere applicaties niet toestaan om %1$s te bedekken of van het scherm te duwen. - Stuur berichten met \"OK\" in Google Chat Bescherming tegen het per ongeluk herhalen van toetsen Uit Export voltooid diff --git a/app/src/main/res/values-pt-rBR/strings.xml b/app/src/main/res/values-pt-rBR/strings.xml index 4c529942..8f310e88 100644 --- a/app/src/main/res/values-pt-rBR/strings.xml +++ b/app/src/main/res/values-pt-rBR/strings.xml @@ -133,7 +133,6 @@ Enviar com \"OK\" no Facebook Messenger Sempre na frente Não permitir que outras aplicações cubram %1$s ou o empurrem para fora do ecrã. - Enviar mensagens com \"OK\" no Google Chat Proteção contra repetição acidental de teclas Desligado Exportação concluída diff --git a/app/src/main/res/values-ru/strings.xml b/app/src/main/res/values-ru/strings.xml index dc5d4602..4ecd1185 100644 --- a/app/src/main/res/values-ru/strings.xml +++ b/app/src/main/res/values-ru/strings.xml @@ -133,7 +133,6 @@ Если вам нравится %1$s, вы можете поддержать его разработку по: %2$s. Поверх других приложений Не разрешать другим приложениям перекрывать %1$s или выталкивать его с экрана. - Отправка сообщения с «ОК» в Google Chat Защита от случайного повторения нажатий Выключена Экспорт завершен diff --git a/app/src/main/res/values-tr/strings.xml b/app/src/main/res/values-tr/strings.xml index f98c82de..11e49d54 100644 --- a/app/src/main/res/values-tr/strings.xml +++ b/app/src/main/res/values-tr/strings.xml @@ -119,7 +119,6 @@ "0" tuşuna iki kere basıldığında yazılacak karakter Her zaman en üstte tut Diğer uygulamaların %1$s ekranını kaplamasına veya ekranın dışına itmesine izin vermeyin. - Google Chat konuşmalarında mesaj göndermek için \"OK\" tuşunu kull an Tuşlara yanlışlıkla birden fazla basma engelleyici Kapalı Dışa aktarma tamamlandı. diff --git a/app/src/main/res/values-uk/strings.xml b/app/src/main/res/values-uk/strings.xml index 0b38077e..a2474824 100644 --- a/app/src/main/res/values-uk/strings.xml +++ b/app/src/main/res/values-uk/strings.xml @@ -54,7 +54,6 @@ Символ при подвійному натискання клавіші 0 Поверх інших програм Не дозволяти іншим програмам перекривати %1$s або змушувати його зникати з екрану. - Відправляти повідомлення по натиску \"OK\" в Google Chat Відправляти повідомлення по натиску \"OK\" в Messenger Захист від випадкового повторення натискань Вимкнено diff --git a/app/src/main/res/values/strings.xml b/app/src/main/res/values/strings.xml index 80c57a66..145ba58a 100644 --- a/app/src/main/res/values/strings.xml +++ b/app/src/main/res/values/strings.xml @@ -71,7 +71,6 @@ Large Always on Top Prevent other apps from covering %1$s or pushing it off the screen. - Send messages with \"OK\" in Google Chat Send with \"OK\" in Facebook Messenger Accidental Key Repeat Protection Off diff --git a/app/src/main/res/xml/prefs_screen_setup.xml b/app/src/main/res/xml/prefs_screen_setup.xml index 17610334..e6570c00 100644 --- a/app/src/main/res/xml/prefs_screen_setup.xml +++ b/app/src/main/res/xml/prefs_screen_setup.xml @@ -15,12 +15,6 @@ - -