homelab/traefik
1
0
Fork 0
Code Activity

Re-add server up metrics

Browse source
This commit is contained in:
Robin Müller 2020-09-26 13:30:03 +02:00 • committed by GitHub
parent 5e63ab619e
commit f2e53a3569
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
3 changed files with 36 additions and 18 deletions
Download patch file Download diff file Expand all files Collapse all files

10
pkg/healthcheck/healthcheck_test.go
View file

@ -120,10 +120,10 @@ func TestSetBackendsConfiguration(t *testing.T) {
backend.disabledURLs = append(backend.disabledURLs, backendURL{url: serverURL, weight: 1})
}
collectingMetrics := testhelpers.NewCollectingHealthCheckMetrics()
collectingMetrics := &testhelpers.CollectingGauge{}
check := HealthCheck{
Backends: make(map[string]*BackendConfig),
metrics: collectingMetrics,
metrics: metricsHealthcheck{serverUpGauge: collectingMetrics},
}
wg := sync.WaitGroup{}
@ -149,8 +149,7 @@ func TestSetBackendsConfiguration(t *testing.T) {
assert.Equal(t, test.expectedNumRemovedServers, lb.numRemovedServers, "removed servers")
assert.Equal(t, test.expectedNumUpsertedServers, lb.numUpsertedServers, "upserted servers")
// FIXME re add metrics
// assert.Equal(t, test.expectedGaugeValue, collectingMetrics.Gauge.GaugeValue, "ServerUp Gauge")
assert.Equal(t, test.expectedGaugeValue, collectingMetrics.GaugeValue, "ServerUp Gauge")
})
}
}
@ -502,9 +501,10 @@ func TestNotFollowingRedirects(t *testing.T) {
FollowRedirects: false,
}, "backendName")
collectingMetrics := &testhelpers.CollectingGauge{}
check := HealthCheck{
Backends: make(map[string]*BackendConfig),
metrics: testhelpers.NewCollectingHealthCheckMetrics(),
metrics: metricsHealthcheck{serverUpGauge: collectingMetrics},
}
wg := sync.WaitGroup{}