homelab/traefik
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions

prefer NoError/Error over Nil/NotNil

Browse source
This commit is contained in:
Stephen Solka 2020-07-19 07:10:03 -04:00 • committed by GitHub
parent 44a244b1cb
commit dcd0cda0c6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

2
pkg/server/middleware/middlewares_test.go
View file

@ -276,7 +276,7 @@ func TestBuilder_BuildChainWithContext(t *testing.T) {
handlers, err := result.Then(http.HandlerFunc(func(w http.ResponseWriter, r *http.Request) { w.WriteHeader(http.StatusOK) }))
if test.expectedError != nil {
require.NotNil(t, err)
require.Error(t, err)
require.Equal(t, test.expectedError.Error(), err.Error())
} else {
require.NoError(t, err)

2
pkg/server/service/tcp/service_test.go
View file

@ -193,7 +193,7 @@ func TestManager_BuildTCP(t *testing.T) {
assert.EqualError(t, err, test.expectedError)
require.Nil(t, handler)
} else {
assert.Nil(t, err)
assert.NoError(t, err)
require.NotNil(t, handler)
}
})

2
pkg/server/service/udp/service_test.go
View file

@ -193,7 +193,7 @@ func TestManager_BuildUDP(t *testing.T) {
assert.EqualError(t, err, test.expectedError)
require.Nil(t, handler)
} else {
assert.Nil(t, err)
assert.NoError(t, err)
require.NotNil(t, handler)
}
})