homelab/traefik
1
0
Fork 0
Code Activity

prefer NoError/Error over Nil/NotNil

Browse source
This commit is contained in:
Stephen Solka 2020-07-19 07:10:03 -04:00 • committed by GitHub
parent 44a244b1cb
commit dcd0cda0c6
No known key found for this signature in database
GPG key ID: 4AEE18F83AFDEB23
5 changed files with 7 additions and 7 deletions
Download patch file Download diff file Expand all files Collapse all files

6
pkg/healthcheck/healthcheck_test.go
View file

@ -448,9 +448,9 @@ func TestLBStatusUpdater(t *testing.T) {
svInfo := &runtime.ServiceInfo{}
lbsu := NewLBStatusUpdater(lb, svInfo)
newServer, err := url.Parse("http://foo.com")
assert.Nil(t, err)
assert.NoError(t, err)
err = lbsu.UpsertServer(newServer, roundrobin.Weight(1))
assert.Nil(t, err)
assert.NoError(t, err)
assert.Equal(t, len(lbsu.Servers()), 1)
assert.Equal(t, len(lbsu.BalancerHandler.(*testLoadBalancer).Options()), 1)
statuses := svInfo.GetAllStatus()
@ -461,7 +461,7 @@ func TestLBStatusUpdater(t *testing.T) {
break
}
err = lbsu.RemoveServer(newServer)
assert.Nil(t, err)
assert.NoError(t, err)
assert.Equal(t, len(lbsu.Servers()), 0)
statuses = svInfo.GetAllStatus()
assert.Equal(t, len(statuses), 1)