homelab/traefik
1
0
Fork 0
Code Activity

Support 3xx HTTP status codes for health check

Browse source
This commit is contained in:
Ondrej Flidr 2018-05-23 17:06:04 +02:00 • committed by Traefiker Bot
parent c09febfffc
commit d6d795e286
3 changed files with 12 additions and 4 deletions
Download patch file Download diff file Expand all files Collapse all files

4
healthcheck/healthcheck.go
View file

@ -203,8 +203,8 @@ func checkHealth(serverURL *url.URL, backend *BackendHealthCheck) error {
defer resp.Body.Close()
if resp.StatusCode < http.StatusOK || resp.StatusCode >= http.StatusMultipleChoices {
return fmt.Errorf("received non-2xx status code: %v", resp.StatusCode)
if resp.StatusCode < http.StatusOK || resp.StatusCode >= http.StatusBadRequest {
return fmt.Errorf("received error status code: %v", resp.StatusCode)
}
return nil

8
healthcheck/healthcheck_test.go
View file

@ -47,6 +47,14 @@ func TestSetBackendsConfiguration(t *testing.T) {
expectedNumUpsertedServers: 0,
expectedGaugeValue: 1,
},
{
desc: "healthy server staying healthy (StatusPermanentRedirect)",
startHealthy: true,
healthSequence: []int{http.StatusPermanentRedirect},
expectedNumRemovedServers: 0,
expectedNumUpsertedServers: 0,
expectedGaugeValue: 1,
},
{
desc: "healthy server becoming sick",
startHealthy: true,