From c9e78c4f4ad3e63409617b7879b21228bc3d06e0 Mon Sep 17 00:00:00 2001 From: Timo Reimann Date: Fri, 3 Feb 2017 09:15:56 +0100 Subject: [PATCH] Fix docker version specifier (#1108) * Fix Docker version specifier. - The download URL[1] does not contain a leading 'v'. - The major version is 1. [1] https://github.com/docker/docker/releases/tag/v1.10.3 * Drop -S and and -f in build.Dockerfile curl commands. - `-f` (`--fail`) turns HTTP error response codes into a non-zero exit code, making curl fail early and properly. While the documentation mentions that there is supposed to be no output, we do see an error message. - `-S` (`--show-error`) is only meaningful when used together with `-s` (`--silent`). We do not want to go silent but see the progress bar though. --- build.Dockerfile | 6 +++--- 1 file changed, 3 insertions(+), 3 deletions(-) diff --git a/build.Dockerfile b/build.Dockerfile index 48f71254a..aaa8dac52 100644 --- a/build.Dockerfile +++ b/build.Dockerfile @@ -6,7 +6,7 @@ RUN go get github.com/jteeuwen/go-bindata/... \ && go get github.com/client9/misspell/cmd/misspell # Which docker version to test on -ARG DOCKER_VERSION=v0.10.3 +ARG DOCKER_VERSION=1.10.3 # Which glide version to test on @@ -14,12 +14,12 @@ ARG GLIDE_VERSION=v0.12.3 # Download glide RUN mkdir -p /usr/local/bin \ - && curl -SL https://github.com/Masterminds/glide/releases/download/${GLIDE_VERSION}/glide-${GLIDE_VERSION}-linux-amd64.tar.gz \ + && curl -fL https://github.com/Masterminds/glide/releases/download/${GLIDE_VERSION}/glide-${GLIDE_VERSION}-linux-amd64.tar.gz \ | tar -xzC /usr/local/bin --transform 's#^.+/##x' # Download docker RUN mkdir -p /usr/local/bin \ - && curl -SL https://get.docker.com/builds/Linux/x86_64/docker-${DOCKER_VERSION}.tgz \ + && curl -fL https://get.docker.com/builds/Linux/x86_64/docker-${DOCKER_VERSION}.tgz \ | tar -xzC /usr/local/bin --transform 's#^.+/##x' WORKDIR /go/src/github.com/containous/traefik