Remove checkStringQuoteValidity in loadIngressRouteConf

* remove checkStringQuoteValidity in loadIngressRouteConf

* remove checkStringQuoteValidity and related tests in crd

* remove checkStringQuoteValidity from ingress and related tests

Co-authored-by: traefiker <30906710+traefiker@users.noreply.github.com>

pkg/provider/kubernetes/crd/fixtures/tcp/with_bad_host_rule.yml

@@ -1,15 +0,0 @@
-apiVersion: traefik.containo.us/v1alpha1
-kind: IngressRouteTCP
-metadata:
-  name: test.route
-  namespace: default
-
-spec:
-  entryPoints:
-    - web
-
-  routes:
-  - match: HostSNI(`foo.com"0"`)
-    services:
-    - name: whoamitcp
-      port: 8000

pkg/provider/kubernetes/crd/fixtures/with_bad_host_rule.yml

@@ -1,17 +0,0 @@
-apiVersion: traefik.containo.us/v1alpha1
-kind: IngressRoute
-metadata:
-  name: test.route
-  namespace: default
-
-spec:
-  entryPoints:
-    - web
-
-  routes:
-  - match: Host(`foo.com"0"`) && PathPrefix(`/bar`)
-    kind: Rule
-    priority: 12
-    services:
-    - name: whoami
-      port: 80

pkg/provider/kubernetes/crd/kubernetes.go

@@ -9,7 +9,6 @@ import (
 	"fmt"
 	"os"
 	"sort"
-	"strconv"
 	"strings"
 	"time"
 
@@ -609,11 +608,6 @@ func buildTLSStores(ctx context.Context, client Client) map[string]tls.Store {
 	return tlsStores
 }
 
-func checkStringQuoteValidity(value string) error {
-	_, err := strconv.Unquote(`"` + value + `"`)
-	return err
-}
-
 func makeServiceKey(rule, ingressName string) (string, error) {
 	h := sha256.New()
 	if _, err := h.Write([]byte(rule)); err != nil {

pkg/provider/kubernetes/crd/kubernetes_http.go

@@ -58,11 +58,6 @@ func (p *Provider) loadIngressRouteConfiguration(ctx context.Context, client Cli
 				continue
 			}
 
-			if err := checkStringQuoteValidity(route.Match); err != nil {
-				logger.Errorf("Invalid syntax for match rule: %s", route.Match)
-				continue
-			}
-
 			serviceKey, err := makeServiceKey(route.Match, ingressName)
 			if err != nil {
 				logger.Error(err)

pkg/provider/kubernetes/crd/kubernetes_tcp.go

@@ -44,11 +44,6 @@ func (p *Provider) loadIngressRouteTCPConfiguration(ctx context.Context, client
 				continue
 			}
 
-			if err := checkStringQuoteValidity(route.Match); err != nil {
-				logger.Errorf("Invalid syntax for match rule: %s", route.Match)
-				continue
-			}
-
 			key, err := makeServiceKey(route.Match, ingressName)
 			if err != nil {
 				logger.Error(err)

pkg/provider/kubernetes/crd/kubernetes_test.go

@@ -372,26 +372,6 @@ func TestLoadIngressRouteTCPs(t *testing.T) {
 				TLS: &dynamic.TLSConfiguration{},
 			},
 		},
-		{
-			desc:  "check rule quoting validity",
-			paths: []string{"tcp/services.yml", "tcp/with_bad_host_rule.yml"},
-			expected: &dynamic.Configuration{
-				UDP: &dynamic.UDPConfiguration{
-					Routers:  map[string]*dynamic.UDPRouter{},
-					Services: map[string]*dynamic.UDPService{},
-				},
-				TCP: &dynamic.TCPConfiguration{
-					Routers:  map[string]*dynamic.TCPRouter{},
-					Services: map[string]*dynamic.TCPService{},
-				},
-				HTTP: &dynamic.HTTPConfiguration{
-					Routers:     map[string]*dynamic.Router{},
-					Middlewares: map[string]*dynamic.Middleware{},
-					Services:    map[string]*dynamic.Service{},
-				},
-				TLS: &dynamic.TLSConfiguration{},
-			},
-		},
 		{
 			desc:  "TLS",
 			paths: []string{"tcp/services.yml", "tcp/with_tls.yml"},
@@ -2149,26 +2129,6 @@ func TestLoadIngressRoutes(t *testing.T) {
 				},
 			},
 		},
-		{
-			desc:  "check rule quoting validity",
-			paths: []string{"services.yml", "with_bad_host_rule.yml"},
-			expected: &dynamic.Configuration{
-				UDP: &dynamic.UDPConfiguration{
-					Routers:  map[string]*dynamic.UDPRouter{},
-					Services: map[string]*dynamic.UDPService{},
-				},
-				TLS: &dynamic.TLSConfiguration{},
-				TCP: &dynamic.TCPConfiguration{
-					Routers:  map[string]*dynamic.TCPRouter{},
-					Services: map[string]*dynamic.TCPService{},
-				},
-				HTTP: &dynamic.HTTPConfiguration{
-					Routers:     map[string]*dynamic.Router{},
-					Middlewares: map[string]*dynamic.Middleware{},
-					Services:    map[string]*dynamic.Service{},
-				},
-			},
-		},
 		{
 			desc:  "TLS",
 			paths: []string{"services.yml", "with_tls.yml"},