Small code enhancements

provider/acme/local_store.go

@@ -188,7 +188,7 @@ func (s *LocalStore) SetHTTPChallengeToken(token, domain string, keyAuth []byte)
 		s.storedData.HTTPChallenges[token] = map[string][]byte{}
 	}
 
-	s.storedData.HTTPChallenges[token][domain] = []byte(keyAuth)
+	s.storedData.HTTPChallenges[token][domain] = keyAuth
 	return nil
 }
 

provider/file/file.go

@@ -76,7 +76,7 @@ func (p *Provider) BuildConfiguration() (*types.Configuration, error) {
 		return p.loadFileConfig(p.TraefikFile, false)
 	}
 
-	return nil, errors.New("Error using file configuration backend, no filename defined")
+	return nil, errors.New("error using file configuration backend, no filename defined")
 }
 
 func (p *Provider) addWatcher(pool *safe.Pool, directory string, configurationChan chan<- types.ConfigMessage, callback func(chan<- types.ConfigMessage, fsnotify.Event)) error {

provider/file/file_test.go

@@ -241,11 +241,15 @@ func TestProvideWithWatch(t *testing.T) {
 			}
 
 			if len(test.fileContent) > 0 {
-				ioutil.WriteFile(provider.Filename, []byte(test.fileContent), 0755)
+				if err := ioutil.WriteFile(provider.Filename, []byte(test.fileContent), 0755); err != nil {
+					t.Error(err)
+				}
 			}
 
 			if len(test.traefikFileContent) > 0 {
-				ioutil.WriteFile(provider.TraefikFile, []byte(test.traefikFileContent), 0755)
+				if err := ioutil.WriteFile(provider.TraefikFile, []byte(test.traefikFileContent), 0755); err != nil {
+					t.Error(err)
+				}
 			}
 
 			if len(test.directoryContent) > 0 {

provider/kubernetes/client.go

@@ -241,7 +241,7 @@ func (c *clientImpl) newResourceEventHandler(events chan<- interface{}) cache.Re
 
 // eventHandlerFunc will pass the obj on to the events channel or drop it.
 // This is so passing the events along won't block in the case of high volume.
-// The events are only used for signalling anyway so dropping a few is ok.
+// The events are only used for signaling anyway so dropping a few is ok.
 func eventHandlerFunc(events chan<- interface{}, obj interface{}) {
 	select {
 	case events <- obj:

provider/kv/kv_mock_test.go

@@ -44,7 +44,7 @@ func newKvClientMock(kvPairs []*store.KVPair, err error) *Mock {
 }
 
 func (s *Mock) Put(key string, value []byte, opts *store.WriteOptions) error {
-	return errors.New("Put not supported")
+	return errors.New("put not supported")
 }
 
 func (s *Mock) Get(key string, options *store.ReadOptions) (*store.KVPair, error) {
@@ -60,7 +60,7 @@ func (s *Mock) Get(key string, options *store.ReadOptions) (*store.KVPair, error
 }
 
 func (s *Mock) Delete(key string) error {
-	return errors.New("Delete not supported")
+	return errors.New("delete not supported")
 }
 
 // Exists mock
@@ -78,7 +78,7 @@ func (s *Mock) Exists(key string, options *store.ReadOptions) (bool, error) {
 
 // Watch mock
 func (s *Mock) Watch(key string, stopCh <-chan struct{}, options *store.ReadOptions) (<-chan *store.KVPair, error) {
-	return nil, errors.New("Watch not supported")
+	return nil, errors.New("watch not supported")
 }
 
 // WatchTree mock

provider/kv/kv_test.go

@@ -5,6 +5,7 @@ import (
 	"time"
 
 	"github.com/abronan/valkeyrie/store"
+	"github.com/containous/traefik/log"
 	"github.com/containous/traefik/types"
 )
 
@@ -22,7 +23,9 @@ func TestKvWatchTree(t *testing.T) {
 
 	configChan := make(chan types.ConfigMessage)
 	go func() {
-		provider.watchKv(configChan, "prefix", make(chan bool, 1))
+		if err := provider.watchKv(configChan, "prefix", make(chan bool, 1)); err != nil {
+			log.Error(err)
+		}
 	}()
 
 	select {

provider/marathon/builder_test.go

@@ -95,12 +95,6 @@ func containerNetwork() func(*marathon.Application) {
 	}
 }
 
-func hostNetwork() func(*marathon.Application) {
-	return func(app *marathon.Application) {
-		app.SetNetwork("host", marathon.HostNetworkMode)
-	}
-}
-
 func ipAddrPerTask(port int) func(*marathon.Application) {
 	return func(app *marathon.Application) {
 		p := marathon.Port{

provider/rancher/metadata.go

@@ -109,7 +109,7 @@ func (p *Provider) longPoll(client rancher.Client, updateConfiguration func(stri
 
 	// Holds the connection until there is either a change in the metadata
 	// repository or `p.RefreshSeconds` has elapsed. Long polling should be
-	// favoured for the most accurate configuration updates.
+	// favored for the most accurate configuration updates.
 	safe.Go(func() {
 		client.OnChange(p.RefreshSeconds, updateConfiguration)
 	})