homelab/traefik
1
0
Fork 0
Code Activity

Validate plugin module name

Browse source 
Co-authored-by: Romain <rtribotte@users.noreply.github.com>
This commit is contained in:
Kevin Pollet 2025-11-20 10:50:04 +01:00 • committed by GitHub
parent 79bb320f4c
commit 9232535cf6
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 88 additions and 8 deletions
Download patch file Download diff file Expand all files Collapse all files

11
pkg/plugins/plugins.go
View file

@ -8,6 +8,7 @@ import (
"github.com/hashicorp/go-multierror"
"github.com/traefik/traefik/v2/pkg/log"
"golang.org/x/mod/module"
)
const localGoPath = "./plugins-local/"
@ -68,24 +69,18 @@ func checkRemotePluginsConfiguration(plugins map[string]Descriptor) error {
var errs []string
for pAlias, descriptor := range plugins {
if descriptor.ModuleName == "" {
errs = append(errs, fmt.Sprintf("%s: plugin name is missing", pAlias))
if err := module.CheckPath(descriptor.ModuleName); err != nil {
errs = append(errs, fmt.Sprintf("%s: malformed plugin module name is missing: %s", pAlias, err))
}
if descriptor.Version == "" {
errs = append(errs, fmt.Sprintf("%s: plugin version is missing", pAlias))
}
if strings.HasPrefix(descriptor.ModuleName, "/") || strings.HasSuffix(descriptor.ModuleName, "/") {
errs = append(errs, fmt.Sprintf("%s: plugin name should not start or end with a /", pAlias))
continue
}
if _, ok := uniq[descriptor.ModuleName]; ok {
errs = append(errs, fmt.Sprintf("only one version of a plugin is allowed, there is a duplicate of %s", descriptor.ModuleName))
continue
}
uniq[descriptor.ModuleName] = struct{}{}
}