homelab/traefik
1
0
Fork 0
Code Activity

Fix HTTP headers not being canonicalized in tracing

Browse source
This commit is contained in:
Maurus Cuelenaere 2025-08-26 15:55:05 +02:00 • committed by GitHub
parent 0bf6442c5d
commit 90702d93ab
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
2 changed files with 67 additions and 2 deletions
Download patch file Download diff file Expand all files Collapse all files

19
pkg/tracing/tracing.go
View file

@ -127,8 +127,8 @@ func NewTracer(tracer trace.Tracer, capturedRequestHeaders, capturedResponseHead
return &Tracer{
Tracer: tracer,
safeQueryParams: safeQueryParams,
capturedRequestHeaders: capturedRequestHeaders,
capturedResponseHeaders: capturedResponseHeaders,
capturedRequestHeaders: canonicalizeHeaders(capturedRequestHeaders),
capturedResponseHeaders: canonicalizeHeaders(capturedResponseHeaders),
}
}
@ -346,3 +346,18 @@ func defaultStatus(code int) (codes.Code, string) {
}
return codes.Unset, ""
}
// canonicalizeHeaders converts a slice of header keys to their canonical form.
// It uses http.CanonicalHeaderKey to ensure that the headers are in a consistent format.
func canonicalizeHeaders(headers []string) []string {
if headers == nil {
return nil
}
canonicalHeaders := make([]string, len(headers))
for i, header := range headers {
canonicalHeaders[i] = http.CanonicalHeaderKey(header)
}
return canonicalHeaders
}