diff --git a/MAINTAINER.md b/MAINTAINER.md index 92771a6a9..a4ea35206 100644 --- a/MAINTAINER.md +++ b/MAINTAINER.md @@ -14,13 +14,23 @@ * Marco Jantke [@marco-jantke](https://github.com/marco-jantke) * Michaël Matur [@mmatur](https://github.com/mmatur) +## Contributions Daily Meeting + +* 3 Maintainers should attend to a Contributions Daily Meeting where we sort and label new issues ([is:issue label:status/0-needs-triage](https://github.com/containous/traefik/issues?utf8=%E2%9C%93&q=is%3Aissue+label%3Astatus%2F0-needs-triage+)), and review every Pull Requests +* Every pull request should be checked during the Contributions Daily Meeting + * Even if it’s already assigned + * Even PR labelled with `contributor/waiting-for-corrections` or `contributor/waiting-for-feedback` +* Issues labeled with `priority/P0` and `priority/P1` should be assigned. +* Modifying an issue (labels, assignees, milestone) is only possible during the Contributions Daily Meeting, or by an assigned maintainer ## PR review process: * The status `needs-design-review` is only used in complex/heavy/tricky PRs. -* From `1` to `2`: 1 design LGTM in comment, by a senior maintainer, if needed. -* From `2` to `3`: 3 LGTM by any maintainer. +* From `status/1-needs-design-review` to `status/2-needs-review`: 1 design LGTM in comment, by a senior maintainer, if needed. +* From `status/2-needs-review` to `status/3-needs-merge`: 3 LGTM by any maintainer. * If needed, a specific maintainer familiar with a particular domain can be requested for the review. +* If a PR has been implemented in pair programming, one peer's LGTM goes into the review for free +* Amending someone else's pull request is authorized only in emergency, if a rebase is needed, or if the initial contributor is silent We use [PRM](https://github.com/ldez/prm) to manage locally pull requests. @@ -130,18 +140,20 @@ If we open/look an issue/PR, we must add a `kind/*`, an `area/*` and a `status/* * `area/websocket`: WebSocket related. * `area/webui`: Web UI related. -### Priority +### Issues Priority -* `priority/P0`: needs hot fix. **(only for issue)** -* `priority/P1`: need to be fixed in next release. **(only for issue)** -* `priority/P2`: need to be fixed in the future. **(only for issue)** -* `priority/P3`: maybe. **(only for issue)** +* `priority/P0`: needs hot fix. +* `priority/P1`: need to be fixed in next release. +* `priority/P2`: need to be fixed in the future. +* `priority/P3`: maybe. ### PR size -* `size/S`: small PR. **(only for PR)** _[bot only]_ -* `size/M`: medium PR. **(only for PR)** _[bot only]_ -* `size/L`: Large PR. **(only for PR)** _[bot only]_ +_Automatically set by a bot_ + +* `size/S`: small PR. +* `size/M`: medium PR. +* `size/L`: Large PR. ### Status - Workflow