homelab/traefik
1
0
Fork 0
Code Activity

Close listener at last sequence to avoid flakiness

Browse source
This commit is contained in:
Landry Benguigui 2025-12-04 15:22:04 +01:00 • committed by GitHub
parent c3d428a16e
commit 206427c4ea
No known key found for this signature in database
GPG key ID: B5690EEEBB952194
1 changed files with 6 additions and 1 deletions
Download patch file Download diff file Expand all files Collapse all files

7
pkg/healthcheck/healthcheck_tcp_test.go
View file

@ -481,7 +481,7 @@ func TestServiceTCPHealthChecker_Launch(t *testing.T) {
} }
// Wait for all health checks to complete deterministically // Wait for all health checks to complete deterministically
for range test.server.StatusSequence { for i := range test.server.StatusSequence {
test.server.Next() test.server.Next()
initialUpserted := lb.numUpsertedServers initialUpserted := lb.numUpsertedServers
@ -490,6 +490,11 @@ func TestServiceTCPHealthChecker_Launch(t *testing.T) {
for time.Now().Before(deadline) { for time.Now().Before(deadline) {
time.Sleep(5 * time.Millisecond) time.Sleep(5 * time.Millisecond)
if lb.numUpsertedServers > initialUpserted || lb.numRemovedServers > initialRemoved { if lb.numUpsertedServers > initialUpserted || lb.numRemovedServers > initialRemoved {
// Stop the health checker immediately after the last expected sequence completes
// to prevent extra health checks from firing and modifying the counters.
if i == len(test.server.StatusSequence)-1 {
cancel()
}
break break
} }
} }