Minor changes

provider/ecs/config_test.go

@@ -496,87 +496,6 @@ func TestFilterInstance(t *testing.T) {
 	}
 }
 
-func TestChunkedTaskArns(t *testing.T) {
-	testVal := "a"
-	testCases := []struct {
-		desc            string
-		count           int
-		expectedLengths []int
-	}{
-		{
-			desc:            "0 parameter should return nil",
-			count:           0,
-			expectedLengths: []int(nil),
-		},
-		{
-			desc:            "1 parameter should return 1 array of 1 element",
-			count:           1,
-			expectedLengths: []int{1},
-		},
-		{
-			desc:            "99 parameters should return 1 array of 99 elements",
-			count:           99,
-			expectedLengths: []int{99},
-		},
-		{
-			desc:            "100 parameters should return 1 array of 100 elements",
-			count:           100,
-			expectedLengths: []int{100},
-		},
-		{
-			desc:            "101 parameters should return 1 array of 100 elements and 1 array of 1 element",
-			count:           101,
-			expectedLengths: []int{100, 1},
-		},
-		{
-			desc:            "199 parameters should return 1 array of 100 elements and 1 array of 99 elements",
-			count:           199,
-			expectedLengths: []int{100, 99},
-		},
-		{
-			desc:            "200 parameters should return 2 arrays of 100 elements each",
-			count:           200,
-			expectedLengths: []int{100, 100},
-		},
-		{
-			desc:            "201 parameters should return 2 arrays of 100 elements each and 1 array of 1 element",
-			count:           201,
-			expectedLengths: []int{100, 100, 1},
-		},
-		{
-			desc:            "555 parameters should return 5 arrays of 100 elements each and 1 array of 55 elements",
-			count:           555,
-			expectedLengths: []int{100, 100, 100, 100, 100, 55},
-		},
-		{
-			desc:            "1001 parameters should return 10 arrays of 100 elements each and 1 array of 1 element",
-			count:           1001,
-			expectedLengths: []int{100, 100, 100, 100, 100, 100, 100, 100, 100, 100, 1},
-		},
-	}
-
-	for _, test := range testCases {
-		test := test
-		t.Run(test.desc, func(t *testing.T) {
-			t.Parallel()
-
-			var tasks []*string
-			for v := 0; v < test.count; v++ {
-				tasks = append(tasks, &testVal)
-			}
-
-			out := chunkedTaskArns(tasks)
-			var outCount []int
-
-			for _, el := range out {
-				outCount = append(outCount, len(el))
-			}
-
-			assert.Equal(t, test.expectedLengths, outCount, "Chunking %d elements", test.count)
-		})
-	}
-}
-
 func TestGetHost(t *testing.T) {
 	testCases := []struct {
 		desc         string

provider/ecs/ecs.go

@@ -227,7 +227,7 @@ func (p *Provider) listInstances(ctx context.Context, client *awsClient) ([]ecsI
 					Cluster: &c,
 				})
 				if err != nil {
-					log.Errorf("Unable to describe tasks for %s", page.TaskArns)
+					log.Errorf("Unable to describe tasks for %v", page.TaskArns)
 				} else {
 					for _, t := range resp.Tasks {
 						tasks[aws.StringValue(t.TaskArn)] = t
@@ -396,19 +396,3 @@ func (p *Provider) loadECSConfig(ctx context.Context, client *awsClient) (*types
 
 	return p.buildConfiguration(instances)
 }
-
-// Provider expects no more than 100 parameters be passed to a DescribeTask call; thus, pack
-// each string into an array capped at 100 elements
-func chunkedTaskArns(tasks []*string) [][]*string {
-	var chunkedTasks [][]*string
-	for i := 0; i < len(tasks); i += 100 {
-		var sliceEnd int
-		if i+100 < len(tasks) {
-			sliceEnd = i + 100
-		} else {
-			sliceEnd = len(tasks)
-		}
-		chunkedTasks = append(chunkedTasks, tasks[i:sliceEnd])
-	}
-	return chunkedTasks
-}