From 03b08d67f0e8f4584ea9e721834c090c0b5e7b5f Mon Sep 17 00:00:00 2001 From: Daniel Tomcej Date: Mon, 21 Jun 2021 15:08:06 -0700 Subject: [PATCH] chore: upgrade linter --- .golangci.toml | 2 ++ build.Dockerfile | 2 +- pkg/middlewares/tracing/mock_tracing_test.go | 2 +- 3 files changed, 4 insertions(+), 2 deletions(-) diff --git a/.golangci.toml b/.golangci.toml index ed8ac7b22..0fc20b794 100644 --- a/.golangci.toml +++ b/.golangci.toml @@ -67,6 +67,7 @@ "scopelint", # Deprecated "interfacer", # Deprecated "maligned", # Deprecated + "golint", # Deprecated "sqlclosecheck", # Not relevant (SQL) "rowserrcheck", # Not relevant (SQL) "lll", # Not relevant @@ -97,6 +98,7 @@ "unparam", # Too strict "godox", # Too strict "forcetypeassert", # Too strict + "tagliatelle", # Not compatible with current tags. ] [issues] diff --git a/build.Dockerfile b/build.Dockerfile index 763808618..4c34406e7 100644 --- a/build.Dockerfile +++ b/build.Dockerfile @@ -19,7 +19,7 @@ RUN mkdir -p /usr/local/bin \ && chmod +x /usr/local/bin/go-bindata # Download golangci-lint binary to bin folder in $GOPATH -RUN curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | bash -s -- -b $GOPATH/bin v1.39.0 +RUN curl -sfL https://install.goreleaser.com/github.com/golangci/golangci-lint.sh | bash -s -- -b $GOPATH/bin v1.41.1 # Download misspell binary to bin folder in $GOPATH RUN curl -sfL https://raw.githubusercontent.com/client9/misspell/master/install-misspell.sh | bash -s -- -b $GOPATH/bin v0.3.4 diff --git a/pkg/middlewares/tracing/mock_tracing_test.go b/pkg/middlewares/tracing/mock_tracing_test.go index ca5fcf4fa..33aac1ee6 100644 --- a/pkg/middlewares/tracing/mock_tracing_test.go +++ b/pkg/middlewares/tracing/mock_tracing_test.go @@ -56,7 +56,7 @@ func (n MockSpan) Tracer() opentracing.Tracer { retu func (n MockSpan) LogEvent(event string) {} func (n MockSpan) LogEventWithPayload(event string, payload interface{}) {} func (n MockSpan) Log(data opentracing.LogData) {} -func (n MockSpan) Reset() { +func (n *MockSpan) Reset() { n.Tags = make(map[string]interface{}) }